Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Not Following Symlink CWD #204

Closed
jvanalst opened this issue Oct 26, 2018 · 1 comment
Closed

Not Following Symlink CWD #204

jvanalst opened this issue Oct 26, 2018 · 1 comment

Comments

@jvanalst
Copy link

Hi,

I don't know if this is intended or not, but it's causing my issues because on Mac OS /tmp is a symbolic link to /private/tmp. On most Unix-y OSs and in AWS Lambdas it is just a regular directory.

The problem comes from mkdir.js:72, or thereabouts where the check for a directory does an fs.lstat (which treats a symlink as a file) instead of an fs.stat (which treats it as a directory).

Just wondering if there's a good reason for preferring lstat to stat? Just curious really, since it's mildly inconvenient (yes I know I should probably use os.tmpdir()).

stkb added a commit to stkb/node-tar that referenced this issue May 25, 2019
This allows CWD to be a symbolic link. Fixes isaacs#204
@stkb
Copy link
Contributor

stkb commented May 25, 2019

I've run into the same problem when using npm link with a package that downloads a binary straight into its own directory (which is a symlink because of npm link). Have created #214 to fix it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants