fix: ignore integrity values for git dependencies #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while this will not remove the values that are being ignored, it does ensure that we don't throw EINTEGRITY errors for git dependencies which expect a specific integrity value. see npm/rfcs#525
wraithgar
reviewed
Feb 22, 2022
| @@ -38,6 +38,13 @@ const addGitPlus = url => url && `git+${url}`.replace(/^(git\+)+/, 'git+') | |||
| class GitFetcher extends Fetcher { | |||
| constructor (spec, opts) { | |||
| super(spec, opts) | |||
|
|
|||
| // we never want to compare integrity for git dependencies: npm/rfcs#525 | |||
wraithgar
approved these changes
Feb 22, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while this will not remove the values that are being ignored, it does
ensure that we don't throw EINTEGRITY errors for git dependencies which
expect a specific integrity value
References
Related to npm/rfcs#525