Skip to content

[BUG] Migrate to node-gyp@^8 #35

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
stramel opened this issue Jul 26, 2021 · 2 comments
Closed

[BUG] Migrate to node-gyp@^8 #35

stramel opened this issue Jul 26, 2021 · 2 comments

Comments

@stramel
Copy link

stramel commented Jul 26, 2021

What / Why

Migrating to node-gyp v8 would remove the package request which has multiple warnings related to it.
Related PR nodejs/node-gyp#2220

  • a warning about usage of older Math.random()

npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

  • a warning about no longer maintained package har-validator usage

npm WARN deprecated har-validator@5.1.5: this library is no longer supported

  • a warning about the package itself (request) being deprecated

npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142

When

  • n/a

Where

  • n/a

How

Current Behavior

  • n/a

Steps to Reproduce

  • n/a

Expected Behavior

  • n/a

Who

  • n/a

References

  • n/a
@wraithgar
Copy link
Member

We can't move to this version of node-gyp in npm@7. See this PR for more info #32

@stramel
Copy link
Author

stramel commented Jul 26, 2021

@wraithgar Ah, sorry about that. Thank you for the link to more information behind the decision!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants