From 52a184ac2e78fa673edc4417306368c76701eda4 Mon Sep 17 00:00:00 2001 From: Matt Oswalt Date: Tue, 30 Jun 2020 13:11:57 -0700 Subject: [PATCH 1/5] Remove comments from networks.go Signed-off-by: Matt Oswalt --- scheduler/networks.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/scheduler/networks.go b/scheduler/networks.go index f7365e67..4c962b5b 100644 --- a/scheduler/networks.go +++ b/scheduler/networks.go @@ -149,8 +149,6 @@ func (s *AntidoteScheduler) createNetwork(sc ot.SpanContext, netIndex int, netNa subnet = connectionSubnet } - // https://github.com/containernetworking/plugins/tree/master/plugins/ipam/static - networkArgs := fmt.Sprintf(`{ "name": "%s", "type": "bridge", @@ -167,13 +165,6 @@ func (s *AntidoteScheduler) createNetwork(sc ot.SpanContext, netIndex int, netNa } }`, networkName, bridgeName, subnet) - // TODO(mierdin): consider updating multus - - // TODO(mierdin): will likely want to do something here that says static if provided, but if not, just do whatever. - // Except if they don't have Connections, they don't have networks, so maybe not. Maybe just assuming static when using connections, this doesn't - // affect eth0 anyways - // Except in the cases of vqfx or any manually configured VM, it would be preferred to just say "please configure any subnet". Maybe both options is good after all - network := &networkcrd.NetworkAttachmentDefinition{ // apiVersion: "k8s.cni.cncf.io/v1", ObjectMeta: meta_v1.ObjectMeta{ From 049ef722646026de8c60eb1ce31b0d8b15c28076 Mon Sep 17 00:00:00 2001 From: Matt Oswalt Date: Tue, 30 Jun 2020 13:17:56 -0700 Subject: [PATCH 2/5] Add clarity to makefile Signed-off-by: Matt Oswalt --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 9a81b312..bbaab919 100644 --- a/Makefile +++ b/Makefile @@ -99,6 +99,9 @@ gengo: # (This is important so that we keep the version of our tools and our vendored libraries identical) install_bins: + echo $$GOPATH + ls -lha $$GOPATH + ls -lha $$GOPATH/pkg/mod/github.com/grpc-ecosystem/ @# Figure out how to make versions dynamic From 7c4e8d8295ef4e3c89e2965d26cf6c3b0b03ebab Mon Sep 17 00:00:00 2001 From: Matt Oswalt Date: Tue, 30 Jun 2020 13:22:24 -0700 Subject: [PATCH 3/5] Add GOPATH to run Signed-off-by: Matt Oswalt --- .github/workflows/go.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index a458d4f8..b13e4426 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -36,7 +36,9 @@ jobs: go mod download make install_bins go get github.com/jteeuwen/go-bindata/... - + env: + GOPATH: /home/runner/go + - name: Check changelog run: hack/check-changelog.sh From db7667c0e4c0b263a359f30bca2eada202eb88cc Mon Sep 17 00:00:00 2001 From: Matt Oswalt Date: Tue, 30 Jun 2020 13:24:19 -0700 Subject: [PATCH 4/5] update changelog Signed-off-by: Matt Oswalt --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c7b4f906..782d6e9e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - Move to Go Modules (finally) and fix txn functions [#191](https://github.com/nre-learning/antidote-core/pull/191) - Image Flavors [#189](https://github.com/nre-learning/antidote-core/pull/189) - Add subnet to Connections configuration [#194](https://github.com/nre-learning/antidote-core/pull/194) +- Move to Github Actions [#195](https://github.com/nre-learning/antidote-core/pull/195/) ## v0.6.2 - May 03, 2020 From 60957fc6efd4df70fb3e7b6b7da8d456e15d42d0 Mon Sep 17 00:00:00 2001 From: Matt Oswalt Date: Tue, 30 Jun 2020 13:36:28 -0700 Subject: [PATCH 5/5] Add GOPATH to other steps Signed-off-by: Matt Oswalt --- .github/workflows/go.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index b13e4426..0151507c 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -44,9 +44,13 @@ jobs: - name: Build run: make + env: + GOPATH: /home/runner/go - name: Test run: make test + env: + GOPATH: /home/runner/go - name: call codecov run: bash <(curl -s https://codecov.io/bash)