Skip to content
This repository was archived by the owner on Dec 3, 2021. It is now read-only.

Lessons are not loading due to forbidden tags in image refs #29

Closed
amosialek opened this issue Jul 30, 2019 · 3 comments
Closed

Lessons are not loading due to forbidden tags in image refs #29

amosialek opened this issue Jul 30, 2019 · 3 comments

Comments

@amosialek
Copy link

https://github.com/nre-learning/nrelabs-curriculum/blob/5b8360ca54e22ae27dd41767c68ed7b1a5801506/lessons/tools/lesson-12-jsnapy/lesson.meta.yaml#L28

As far as I know above line is no longer valid since following PR has disabled tags: nre-learning/antidote-core@3a6643e

if strings.Contains(ep.Image, ":") {
			log.Error("Tags are not allowed in endpoint image refs")
			return fail
		}foll

Tools and Workflows are not loading properly. Logs from syringed:

time="2019-07-30T18:45:18Z" level=debug msg="Searching /antidote/lessons for lesson definitions"
time="2019-07-30T18:45:18Z" level=debug msg="Found lesson definition at: /antidote/lessons/fundamentals/lesson-1-demo/lesson.meta.yaml"
time="2019-07-30T18:45:18Z" level=debug msg="Found lesson definition at: /antidote/lessons/fundamentals/lesson-14-yaml/lesson.meta.yaml"
time="2019-07-30T18:45:18Z" level=debug msg="Found lesson definition at: /antidote/lessons/fundamentals/lesson-16-jinja/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/fundamentals/lesson-17-git/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/fundamentals/lesson-19-restapis/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/fundamentals/lesson-22-python/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/fundamentals/lesson-23-linux/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/fundamentals/lesson-50-bash/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-12-jsnapy/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-13-napalm/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-15-stackstorm/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-18-todd/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-24-pyez/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-25-junosjet/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-26-openconfig/lesson.meta.yaml"
time="2019-07-30T18:45:19Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-29-robot/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-30-salt/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-31-terraform/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=debug msg="Found lesson definition at: /antidote/lessons/tools/lesson-59-jsnapy2/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=debug msg="Found lesson definition at: /antidote/lessons/workflows/lesson-21-tshoot-ipphone/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=debug msg="Found lesson definition at: /antidote/lessons/workflows/lesson-32-stigcompliance/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=debug msg="Found lesson definition at: /antidote/lessons/workflows/lesson-33-quickdeviceinventory/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=debug msg="Found lesson definition at: /antidote/lessons/workflows/lesson-34-configbackup/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=debug msg="Found lesson definition at: /antidote/lessons/workflows/lesson-35-devicespecifictemplate/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/fundamentals/lesson-1-demo/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/fundamentals/lesson-14-yaml/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=info msg="Successfully imported lesson 14: Introduction to YAML  with 1 endpoints."
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/fundamentals/lesson-16-jinja/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=info msg="Successfully imported lesson 16: Using Jinja for Configuration Templates  with 1 endpoints."
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/fundamentals/lesson-17-git/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=info msg="Successfully imported lesson 17: Version Control with Git  with 1 endpoints."
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/fundamentals/lesson-19-restapis/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/fundamentals/lesson-22-python/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=info msg="Successfully imported lesson 22: Introduction to Python  with 1 endpoints."
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/fundamentals/lesson-23-linux/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=info msg="Successfully imported lesson 23: Linux Basics  with 1 endpoints."
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/fundamentals/lesson-50-bash/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=info msg="Successfully imported lesson 50: Introduction to BASH  with 1 endpoints."
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-12-jsnapy/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-13-napalm/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-15-stackstorm/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-18-todd/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-24-pyez/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-25-junosjet/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-26-openconfig/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-29-robot/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-30-salt/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-31-terraform/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/tools/lesson-59-jsnapy2/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/workflows/lesson-21-tshoot-ipphone/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/workflows/lesson-32-stigcompliance/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/workflows/lesson-33-quickdeviceinventory/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/workflows/lesson-34-configbackup/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=info msg="Importing lesson definition at: /antidote/lessons/workflows/lesson-35-devicespecifictemplate/lesson.meta.yaml"
time="2019-07-30T18:45:20Z" level=error msg="Tags are not allowed in endpoint image refs"
time="2019-07-30T18:45:20Z" level=warning msg="Imported 6 lesson definitions with errors."
time="2019-07-30T18:45:20Z" level=warning msg="Not all lesson definitions were imported"
time="2019-07-30T18:45:20Z" level=info msg="No syringe-managed namespaces found. Starting normally."
time="2019-07-30T18:45:20Z" level=info msg="Syringe API started." HTTP Port=8086 gRPC Port=50099
time="2019-07-30T18:45:20Z" level=debug msg="No syringe-managed namespaces found. No need to GC."
@amosialek
Copy link
Author

Just found out that this is addressed in one of Pull Requests. This is little disappointing because syringe has been merged to master over 14 hours ago and everyone who tries to pull and start selfmedicate will have third of content on antidote website :/

@Mierdin
Copy link
Member

Mierdin commented Jul 30, 2019

The latest master for any antidote project is not meant to be viewed as stable, or anything that represents the production NRE Labs site, which uses only released versions for all artifacts.

Can I ask a clarifying question - in what capacity are you running selfmedicate? Are you actively working on a lesson?

@Mierdin Mierdin transferred this issue from nre-learning/nrelabs-curriculum Jul 30, 2019
@Mierdin Mierdin reopened this Jul 30, 2019
@Mierdin
Copy link
Member

Mierdin commented Jul 30, 2019

On second thought, because of the fact that selfmedicate still uses latest (which will change once 0.4.0 is out) we need to make sure the new images we're playing with in nre-learning/nrelabs-curriculum#248 are properly vetted before making this Syringe change.

This is likely to take some time, so I reverted this requirement in nre-learning/antidote-core#121 so if you pull the latest syringe now, this should be fixed. Note that we'll be re-implementing this restriction in the near future, but we'll be ready with a compatible curriculum when we do that.

Sorry for the inconvenience.

@Mierdin Mierdin closed this as completed Jul 30, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants