-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[#863] Placed Dependencies and Dependency Versions In TOML file #885
Merged
iadgovuser29
merged 30 commits into
main
from
v3_issue_863-write-dependencies-version-numbers-in-gradleproperties-file
Jan 13, 2025
Merged
[#863] Placed Dependencies and Dependency Versions In TOML file #885
iadgovuser29
merged 30 commits into
main
from
v3_issue_863-write-dependencies-version-numbers-in-gradleproperties-file
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrently replacing dependencies listed in the build.gradle file with the ones referenced in the toml file
…ndencies versions and the ci/cd pipeline in git. will update each depedency slowly to ensure that upgrades are down correctly.
…github's ci/cd is happy still with these set of changes.
…github's ci/cd is happy still with these set of changes (again)
…github's ci/cd is happy still with these set of changes (again) partIII
…is happy still with these set of changes (again)
…s happy still with these set of changes (again)
…ansition to newer spring.
…an unused dependency.
…tical vulnerable dependendcies
…guring what to do with the remaining vulnerabilities.
…, now figuring what to do with the remaining vulnerabilities.
…ability issues will be addressed in another PR. I've cut down vulnerabilities by quite a lot and I want to test the new OWASP plugin against the remaining vulnerabilities.
…es and removed unused one.
chubtub
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
… with spring junit.
iadgovuser29
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested provisioning and ACA behavior in real settings and everything appears to work as expected.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've observed that many dependencies in our build.gradle and settings.gradle files have hard-coded version numbers. To streamline the process of managing these versions, this PR consolidates all the dependencies in one easy-to-access file.
Test Instructions using the Gradle build command:
./gradlew clean --refresh-dependencies build
command and verify that not only does this command pull all of the new dependencies but it also builds the entire application without any issues.Test Instructions using the RPM/Debian file:
Another way to confirm that these changes are good is by building an RPM and installing then running the HIRS-ACA service (building the RPM requires building and assembling all the artifacts and running the ACA service locally).
Stop the current HIRS-ACA runing on your device (assuming you already have one running)
On Rhel Linux distros:
or on a Debian-based Linux distribution:
On Rhel-based distros:
On Debian-based distros:
On Rhel-based distros:
On Debian-based distros:
Summary Of Updates:
Dependencies Changes:
(Certain dependencies have been omitted if they have been replaced by one of
the below dependencies or if their versions haven't changed)
Issues this PR addresses:
Closes #863