Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add pyqtgraph and igor to nsls2-analysis metapackage #20

Closed
mrakitin opened this issue Aug 25, 2020 · 4 comments · Fixed by nsls-ii-forge/nsls2-analysis-feedstock#11
Closed

Comments

@mrakitin
Copy link
Collaborator

Used by NSLS-II-ESM-1/profile_collection#42 (comment).

@mrakitin
Copy link
Collaborator Author

@mrakitin
Copy link
Collaborator Author

Also add legacy-suitcase (#19).

@mrakitin
Copy link
Collaborator Author

Before I go too far, just wanted to discuss it. Installing the legacy-suitcase package (the old suitcase=0.7.0 from the lightsource2-tag conda channel) in the environment with the nsls2-analysis=2020C2.0* metapackage does not seem to break anything as we thought before. It adds 3 modules to the package, which are unique so far (hdf5, spec, and nexus) for which we don't have same-named suitcases, so there is no collision. I think it's OK to package the legacy and new suitcases together.

image

$ ls -al lib/python3.7/site-packages/suitcase
total 172
drwxr-xr-x  13 builder builder  4096 Aug 26 03:37 .
drwxr-xr-x 581 builder builder 36864 Aug 26 03:37 ..
-rw-rw-r--   2 builder builder   442 Aug 26 03:10 __init__.py
drwxr-xr-x   2 builder builder  4096 Aug 26 03:37 __pycache__
-rw-rw-r--   2 builder builder   471 Aug 26 03:10 _version.py
drwxr-xr-x   3 builder builder  4096 Aug 26 03:27 csv
-rw-rw-r--   2 builder builder  7146 Aug 26 03:10 hdf5.py
drwxr-xr-x   4 builder builder  4096 Aug 26 03:26 json_metadata
drwxr-xr-x   4 builder builder  4096 Aug 26 03:27 jsonl
drwxr-xr-x   4 builder builder  4096 Aug 26 03:27 mongo_embedded
drwxr-xr-x   4 builder builder  4096 Aug 26 03:27 mongo_normalized
drwxr-xr-x   3 builder builder  4096 Aug 26 03:27 msgpack
-rw-rw-r--   2 builder builder 11301 Aug 26 03:10 nexus.py
-rw-rw-r--   2 builder builder 54948 Aug 26 03:10 spec.py
drwxr-xr-x   4 builder builder  4096 Aug 26 03:27 specfile
drwxr-xr-x   4 builder builder  4096 Aug 26 03:26 tiff_series
drwxr-xr-x   4 builder builder  4096 Aug 26 03:26 tiff_stack
drwxr-xr-x   4 builder builder  4096 Aug 26 03:27 utils

@danielballan, @tacaswell -- thoughts?

@mrakitin
Copy link
Collaborator Author

mrakitin commented Sep 4, 2020

I did not get the feedback. The legacy-suitcase is going to be deployed with 2020-2.0rc8 envs, then we can test it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant