Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

"SignToolTasks.SignToolPath" can't find the correct path for signtool.exe #1186

Open
gustavocalheiros opened this issue May 31, 2023 · 0 comments · May be fixed by #1188
Open

"SignToolTasks.SignToolPath" can't find the correct path for signtool.exe #1186

gustavocalheiros opened this issue May 31, 2023 · 0 comments · May be fixed by #1188
Assignees
Labels

Comments

@gustavocalheiros
Copy link

gustavocalheiros commented May 31, 2023

Usage Information

Nuke.Common 7.0.2 / Microsoft.NET 4.8.1 / Windows 10

Description

When trying to run "SignToolTasks.SignTool()", I have the following error:

System.ArgumentException: Expected condition to be true (Parameter 'toolPath != null')
at Nuke.Common.Assert.True(Boolean condition, String message, String argumentExpression) in /_/source/Nuke.Common/Assert.cs:line 34

"SignToolTasks.SignToolPath" looks for an old array of paths that don't correspond anymore with the latest windows kits released.
(current code: https://github.com/nuke-build/nuke/blob/develop/source/Nuke.Common/Tools/SignTool/SignToolSettings.cs)

For instance, I have "signtool.exe" installed on the path: "C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\x64\signtool.exe" (and the env variable "SIGNTOOL_EXE" not set)

Reproduction Steps

Install any Windows Kit 10.*

Expected Behavior

signtool should work without problems

Actual Behavior

An exception is thrown

Regression?

No response

Known Workarounds

Set manually the env variable "SIGNTOOL_EXE" with the correct path.

Could you help with a pull-request?

Yes

gustavocalheiros pushed a commit to gustavocalheiros/nuke that referenced this issue May 31, 2023
@gustavocalheiros gustavocalheiros linked a pull request May 31, 2023 that will close this issue
3 tasks
@matkoch matkoch removed the triage label Jun 27, 2023
@matkoch matkoch linked a pull request Jun 27, 2023 that will close this issue
3 tasks
gustavocalheiros pushed a commit to gustavocalheiros/nuke that referenced this issue Apr 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants