Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Optimization for Computational graph #165

Closed
peter0627ustc opened this issue Dec 6, 2023 · 0 comments
Closed

Optimization for Computational graph #165

peter0627ustc opened this issue Dec 6, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@peter0627ustc
Copy link
Collaborator

peter0627ustc commented Dec 6, 2023

After I visualized the computational graph through the compile_dot function, by inspecting the simplest graph (1,0,0) for GV and parquet algorithm, I found some optimizations don't work. As the graph show below:
For the parquet graph:
G100_par
It's obvious to see that there are still trivial unary chains,
The same situation happen for the GV graph
G100
The reason may be that the factor of some nodes is not 1.

@peter0627ustc peter0627ustc added the bug Something isn't working label Dec 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant