diff --git a/students/NorbertLoh/knowledge.md b/students/NorbertLoh/knowledge.md index a516e53e..ba00e22b 100644 --- a/students/NorbertLoh/knowledge.md +++ b/students/NorbertLoh/knowledge.md @@ -17,4 +17,10 @@ WATcher requires node 14 in order to `npm install` some of its dependencies. How While working on creating a new phase, I learnt a lot about how phases are managed in CATcher. Every phase has its own phase permissions and phase routing. Phase permissions controls certain tasks. For example, creating a new issue, deleting an issue, editing an issue is only allowed at certain phases. Every phase also has its own routing which is used to load the different pages ranging from, viewing to editing. I also learnt that the repos to hold the issues are generated only at the bug reporting phase. ### Git commit hooks -While I was working on a PR, I was wondering why certain parts of the code are modified after pushing a commit. I then found out that there are commit hooks in place to fix and format and lint issues. Source tree actually allows users to bypass the commit hooks if the changes are irrelevant to the PR that the user is working on. \ No newline at end of file +While I was working on a PR, I was wondering why certain parts of the code are modified after pushing a commit. I then found out that there are commit hooks in place to fix and format and lint issues. Source tree actually allows users to bypass the commit hooks if the changes are irrelevant to the PR that the user is working on. + +### Github search query +While working on implementing the feature 'View on github' for WATcher where a user will be able to see the current dashboard in github, I learnt that github searches can actually be done using URL queries. + +### URL encoding +While working with URL queries, I learnt that some characters are not allowed in URLs. Such characters are "!"$$()" etc. In order to use them, they must be encoded into UTF-8. More information can be found [here](https://www.w3schools.com/tags/ref_urlencode.ASP). \ No newline at end of file diff --git a/students/NorbertLoh/progress.md b/students/NorbertLoh/progress.md index 1839ee66..9d4ff376 100644 --- a/students/NorbertLoh/progress.md +++ b/students/NorbertLoh/progress.md @@ -4,5 +4,12 @@ | 2 | Submitted Issue: [Invalid tester response example #1299](https://github.com/CATcher-org/CATcher/issues/1299) | | 3 | Submitted Issue: [Remove magic strings for filters #399](https://github.com/CATcher-org/WATcher/issues/399) | | 3 | Merged PR: [Remove magic strings #400](https://github.com/CATcher-org/WATcher/pull/400) | +| 4 | Participated in Issue Investigation: [New bug selection phase requirement #1301](https://github.com/CATcher-org/CATcher/issues/1301) | | 4 | Submitted Issue: [Create new phase for bug trimming #1306](https://github.com/CATcher-org/CATcher/issues/1306) | -| 4 | Merged: [Create new phase for bug trimming #1308](https://github.com/CATcher-org/CATcher/pull/1308) | \ No newline at end of file +| 4 | Merged: [Create new phase for bug trimming #1308](https://github.com/CATcher-org/CATcher/pull/1308) | +| 5 | Submitted Issue: [Include new bug trimming phase #4](https://github.com/CATcher-org/public_data/issues/4) | +| 5 | Reviewed PR: [Add strikethrough to deleted tables #1325](https://github.com/CATcher-org/CATcher/pull/1325) | +| 6 | Merged PR: [Add new bug trimming phase #5](https://github.com/CATcher-org/public_data/pull/5) | +| 6 | Reviewed PR: [Remove feature branch from github-actions.yml #1329](https://github.com/CATcher-org/CATcher/pull/1329) | +| 6 | Created PR: [Merge Feature bug trimming branch to main #1331](https://github.com/CATcher-org/CATcher/pull/1331) | +| 6 | Created PR: [Fix view on GitHub #414](https://github.com/CATcher-org/WATcher/pull/414) | \ No newline at end of file