Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add e2e test for switching between HelmAddon and ClusterResourceSet strategies #394

Open
jimmidyson opened this issue Feb 24, 2024 · 2 comments
Open

Add e2e test for switching between HelmAddon and ClusterResourceSet strategies #394

jimmidyson opened this issue Feb 24, 2024 · 2 comments

Comments

@jimmidyson
Copy link
Member

jimmidyson commented Feb 24, 2024 •
edited
Loading

From @dkoshkin's comment in #393 (comment)

I noticed these Helm labels in other addons, I guess its not a problem for these to be here if not actually managed by helm? I also wonder if there is a helm controller if it tries to "adopt" them.
@jimmidyson jimmidyson mentioned this issue Feb 24, 2024
Merged
@dkoshkin
Copy link
Contributor

Haha I asked because I was thinking of the scenario where we didn't want this adoption to happen. But this is still a good test to know one way or the other.

@jimmidyson
Copy link
Member Author

jimmidyson commented Feb 24, 2024 •
edited
Loading

@dkoshkin Yeah i need to work on kubernetes-sigs/cluster-api#9239 before we can mark variables/properties as immutable.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimmidyson @dkoshkin