Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat!: custom amp styles #206

Merged
merged 7 commits into from
Dec 12, 2020
Merged

feat!: custom amp styles #206

merged 7 commits into from
Dec 12, 2020

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Dec 3, 2020

Change AMP module styling behavior

  • From now on all styles (inline/link) will be removed from AMP pages.
  • AMP page have their own custom CSS, the file is located in ~/assets/styles/amp-custom.css. When the CSS file is missing in the project, AMP pages will not have <style amp-custom> tag.
  • The CSS path is customizable in nuxt.config

@pi0 pi0 changed the title feat: custom amp styles feat!: custom amp styles Dec 3, 2020
lib/module.js Outdated Show resolved Hide resolved
lib/utils.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #206 (239aa28) into master (c39c47e) will decrease coverage by 1.37%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   67.03%   65.66%   -1.38%     
==========================================
  Files           4        5       +1     
  Lines         179      166      -13     
  Branches       48       46       -2     
==========================================
- Hits          120      109      -11     
+ Misses         43       41       -2     
  Partials       16       16              
Impacted Files Coverage Δ
lib/runtime/components.js 0.00% <0.00%> (ø)
lib/runtime/plugin.js 59.70% <50.00%> (ø)
lib/module.js 65.38% <100.00%> (-2.09%) ⬇️
lib/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39c47e...239aa28. Read the comment docs.

@farnabaz farnabaz merged commit 3950c70 into master Dec 12, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants