Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: keep font provides styles #217

Merged
merged 3 commits into from
Dec 23, 2020
Merged

fix: keep font provides styles #217

merged 3 commits into from
Dec 23, 2020

Conversation

farnabaz
Copy link
Member

Do not remove style of font providers that listed in https://amp.dev/documentation/guides-and-tutorials/develop/style_and_layout/custom_fonts/

close #214

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #217 (ffe7947) into master (df3b146) will increase coverage by 1.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   66.66%   67.79%   +1.12%     
==========================================
  Files           5        5              
  Lines         171      177       +6     
  Branches       48       49       +1     
==========================================
+ Hits          114      120       +6     
  Misses         41       41              
  Partials       16       16              
Impacted Files Coverage Δ
lib/module.js 67.85% <100.00%> (+0.38%) ⬆️
lib/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df3b146...ffe7947. Read the comment docs.

@farnabaz farnabaz merged commit c71406b into master Dec 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Google fonts link rel="stylesheet" href="https://fonts.googleapis.com/ with the new release
1 participant