Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(styling): keep Nuxt style when css=false #218

Merged
merged 3 commits into from
Dec 24, 2020
Merged

feat(styling): keep Nuxt style when css=false #218

merged 3 commits into from
Dec 24, 2020

Conversation

farnabaz
Copy link
Member

When project are mainly targeted for AMP, removing styles creates bad DX. On the pure AMP project developers should should be able to define styles in SFC.
This PR creates a solution to disable style removal for the pure amp project.

close #215 #216

This is useful on pure amp project. With this developer can use SFC styling.
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #218 (480693d) into master (c71406b) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   67.79%   67.77%   -0.02%     
==========================================
  Files           5        5              
  Lines         177      180       +3     
  Branches       49       50       +1     
==========================================
+ Hits          120      122       +2     
- Misses         41       42       +1     
  Partials       16       16              
Impacted Files Coverage Δ
lib/module.js 67.81% <66.66%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71406b...480693d. Read the comment docs.

@farnabaz farnabaz merged commit fdad34b into master Dec 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amp with tailwind - generated style without amp-custom
1 participant