-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(core) : owasp default values #450
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Baroshem could you please check the new default values ?
let me know what you want to do |
Hey there! Sorry for no contact from my side as I was quite budy recently. I would update every property do that we will be up to date with the current state of Owasp and I think I would go for a cheatsheet. I went with Node.js Security Cheatsheet when I was implementing other features. |
Actually I compared the cheatsheet with the recommendation and they are pretty close. The only significant difference is on permissions policy, where the cheat sheet only gives an example but the Best Practice is way more strict. |
Awesome, thank you for looking into that! |
After in-depth review, I think it is better to not make further changes:
I'm marking this PR as ready, let me know if good to you @Baroshem |
06c2641
to
944acbc
Compare
Your comment is valid - let's not add these values and be up to date with MDN. Thanks for that! I will be merging this PR to the RC branch :) |
Closes #232
Types of changes
Description
This PR updates the default configuration values of Security Headers to conform to the OWASP recommendations
See OWASP Secure Headers Project
Checklist: