Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: devtools being blocked in strict mode #531

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

dungsil
Copy link
Contributor

@dungsil dungsil commented Sep 30, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix devtools being blocked when strict mode is enabled

88dbb4c the existing documentation has been removed, so it should work the same in strict mode as in none-strict mode

ref: #487

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 10:31am

@Baroshem
Copy link
Owner

Baroshem commented Oct 3, 2024

Hey @dungsil

Thanks for this PR. @vejja do you think we could change that to allow DevTools to work in Strict? DevTools will work only in development so the code proposed by @dungsil shouldn't affect the production env in any way.

@dungsil
Copy link
Contributor Author

dungsil commented Oct 7, 2024

For strict mode, I think it might be a good idea to provide documentation the same as v1.0. Like adding this to the Advanced > Strict CSP document:

@vejja
Copy link
Collaborator

vejja commented Oct 8, 2024

Hi
Yes this change is ok
By the way we should probably think about refactoring the Advanced > Strict CSP section because it is now a source of confusion: the strict default config has no relationship with Strict CSP.
That section was initially intended as a user guide when we didn't have reasonable defaults that allowed CSP to work in all setups. We have much less issues and questions raised now.

@Baroshem Baroshem changed the base branch from main to chore/2.1.0 October 8, 2024 09:20
@Baroshem Baroshem merged commit 9a2e4df into Baroshem:chore/2.1.0 Oct 8, 2024
3 checks passed
@Baroshem
Copy link
Owner

Baroshem commented Oct 8, 2024

Thanks @dungsil @vejja I have merged this PR to 2.1.0 branch that will be used to release a new major version :)

@dargmuesli
Copy link
Contributor

I think major would be a 3.x.x, 2.1.x should be a "feature" level release. This being a fix could've translated into a quick 2.0.1 also 😁

@Baroshem
Copy link
Owner

Baroshem commented Oct 8, 2024

I think major would be a 3.x.x, 2.1.x should be a "feature" level release. This being a fix could've translated into a quick 2.0.1 also 😁

Correct, I meant minor 2.1.0. Thanks for correcting! :)

@dungsil dungsil deleted the strict-devtools branch October 10, 2024 08:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants