Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(sri): incorrect cdnUrl resolution #536

Merged
merged 4 commits into from
Oct 24, 2024
Merged

fix(sri): incorrect cdnUrl resolution #536

merged 4 commits into from
Oct 24, 2024

Conversation

vejja
Copy link
Collaborator

@vejja vejja commented Oct 12, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #535

This PR fixes an incorrect resolution of url paths in the sriHashes table, when a cdnURL option is passed to Nuxt with a path component

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 0:01am

Copy link
Owner

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Baroshem Baroshem changed the base branch from main to chore/2.1.0 October 15, 2024 08:48
@Baroshem
Copy link
Owner

@vejja

Feel free to merge when you are ready. I have changed the base branch from main to 2.1.0 as I would love to see this as a part of next minor release :)

@vejja vejja merged commit a9bee58 into chore/2.1.0 Oct 24, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants