-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enhance header filtering in getHeadersApplicableToAllResources function to exclude falsy values #588
Conversation
…on to exclude falsy values
@ivanvakulov Thank you very much for this PR |
Co-authored-by: vejja <sraffray@yahoo.fr>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@vejja Thank you for the review. I've added new tests for publicAssets to ensure there are no empty headers and that headers are correctly set according to the routeRules. |
@Baroshem LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @ivanvakulov
Thanks @vejja for checking it!
Types of changes
Description
This pull request includes a small change to the
src/utils/headers.ts
file. The change ensures that only headers with non-falsy values are included in the result.src/utils/headers.ts
: Added a filter to remove headers with falsy values in thegetHeadersApplicableToAllResources
function.Checklist: