Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: don't install @nuxtjs/eslint-config and @nuxtjs/eslint-config-typescript together #633

Merged
merged 1 commit into from
Oct 19, 2020
Merged

feat: don't install @nuxtjs/eslint-config and @nuxtjs/eslint-config-typescript together #633

merged 1 commit into from
Oct 19, 2020

Conversation

tillsanders
Copy link
Contributor

Just a minor optimization of the generated package.json. The documentation of nuxt-ts states:

If you're already using @nuxtjs/eslint-config, remove it from your dependencies, the Nuxt TypeScript ESLint config includes it.

@tillsanders
Copy link
Contributor Author

I don't believe this can cause any problems, except maybe duplicate versions and just being a tiny bit confusing. Stumbled upon this in a recent project :D

@clarkdo clarkdo requested a review from kevinmarrec October 7, 2020 17:59
@clarkdo clarkdo merged commit 60795d1 into nuxt:master Oct 19, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@clarkdo clarkdo clarkdo approved these changes

@kevinmarrec kevinmarrec Awaiting requested review from kevinmarrec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tillsanders @clarkdo