Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: update design #792

Merged
merged 8 commits into from
Jun 13, 2021
Merged

feat: update design #792

merged 8 commits into from
Jun 13, 2021

Conversation

atinux
Copy link
Member

@atinux atinux commented May 26, 2021

Should look like this now:

Screenshot 2021-05-26 at 18 53 33

@atinux atinux requested a review from clarkdo May 26, 2021 16:55
@pi0
Copy link
Member

pi0 commented May 26, 2021 •
edited
Loading

Shall we keep icon.png? (or conditionally for pwa selection) since it is used to generate actual pwa icons as well as favicon.

@atinux Volta.net
Copy link
Member Author

atinux commented May 26, 2021

Already conditionally added, see https://github.com/nuxt/create-nuxt-app/blob/feat/design-update/packages/create-nuxt-app/lib/saofile.js#L69

@pi0
Copy link
Member

pi0 commented May 26, 2021

icon is fine. sorry gh diff was showing icon.png removed

clarkdo
clarkdo approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vuetify template also has logo component, should we remove as well ?

https://github.com/nuxt/create-nuxt-app/blob/master/packages/cna-template/template/frameworks/vuetify/components/Logo.vue

@atinux Volta.net
Copy link
Member Author

atinux commented May 26, 2021

Yes, do you mind updating the PR? 🙏

When good; feel free to merge and release 🔥

@clarkdo
Copy link
Member

clarkdo commented May 26, 2021

OK， I’ll update and do some tests tmr

@clarkdo
Copy link
Member

clarkdo commented May 29, 2021 •
edited
Loading

@atinux Can you send me svg file of the new logo ? No worries, extracted it from Tutorial.vue

@clarkdo
Copy link
Member

clarkdo commented May 29, 2021

@atinux @pi0 Updated, can you review ?

@atinux
Copy link
Member Author

atinux commented May 29, 2021

Good for me @clarkdo

@clarkdo clarkdo requested a review from pi0 May 29, 2021 22:06
@clarkdo clarkdo merged commit b7d2db9 into master Jun 13, 2021
@clarkdo clarkdo deleted the feat/design-update branch June 13, 2021 19:51
scscgit added a commit to scscgit/create-nuxt-app that referenced this pull request Aug 1, 2021
@scscgit
fix: add middleware directory missed by nuxt#792 to project readme
f8c9d33
@scscgit scscgit mentioned this pull request Aug 1, 2021
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@clarkdo clarkdo clarkdo approved these changes

@pi0 pi0 Awaiting requested review from pi0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atinux @pi0 @clarkdo