Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add remark-github plugin to bundle #34

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

farnabaz
Copy link
Collaborator

πŸ”— Linked issue

resolves #33

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

/cc @pi0 @danielroe It is strange that when I add the package name to the traceInclude, rollup raise an exception

Screenshot 2022-08-19 at 11 53 29

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 19, 2022

❌ Deploy Preview for nuxt-github-module failed.

Name Link
πŸ”¨ Latest commit ff0810c
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-github-module/deploys/62ff5db0cdc3a60008a1a806

@danielroe
Copy link
Collaborator

Have you tried resolving the package entrypoint and passing the full path?

@farnabaz
Copy link
Collaborator Author

@daniel It is not working since nitro resolves it and passes its id to nft. If I resolve and use the full path the id will be 'remark-github' and again it will raise the same error. The only workaround I found is 'node_modules/remark-github/index.js', but I don't think it is a good thing to do.

https://github.com/unjs/nitro/blob/feebf8f6fda08873452c826e89327db380a495c7/src/rollup/plugins/externals.ts#L139-L144

@danielroe
Copy link
Collaborator

Ahh, I see what you're saying.

@atinux
Copy link
Member

atinux commented Aug 22, 2022

Good for me to merge and release @farnabaz

@farnabaz farnabaz merged commit 9d0236b into main Aug 22, 2022
@farnabaz farnabaz deleted the fix/bundle-remark-github branch August 22, 2022 17:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse content for releases throw error only on production
3 participants