-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: node modules components #38
Merged
farnabaz
merged 13 commits into
nuxtlabs:main
from
stafyniaksacha:fix/node-modules-components
Aug 29, 2022
Merged
fix: node modules components #38
farnabaz
merged 13 commits into
nuxtlabs:main
from
stafyniaksacha:fix/node-modules-components
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnabaz
reviewed
Aug 29, 2022
farnabaz
reviewed
Aug 29, 2022
@farnabaz should be done ;) |
farnabaz
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes components dir to generated
tsconfig
used to parse component meta.If we include all
node_modules
, the app start time is really affected.We can add
node_modules/nuxt/dist/app/components
so native nuxt components will be typed too.Modules which register components dirs should become before this module
Close #37