Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: node modules components #38

Merged
merged 13 commits into from
Aug 29, 2022

Conversation

stafyniaksacha
Copy link
Collaborator

@stafyniaksacha stafyniaksacha commented Aug 29, 2022

This PR includes components dir to generated tsconfig used to parse component meta.
If we include all node_modules, the app start time is really affected.

We can add node_modules/nuxt/dist/app/components so native nuxt components will be typed too.

Modules which register components dirs should become before this module

Close #37

@stafyniaksacha stafyniaksacha changed the title Fix/node modules components fix: node modules components Aug 29, 2022
@stafyniaksacha
Copy link
Collaborator Author

@farnabaz should be done ;)

Copy link
Collaborator

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@farnabaz farnabaz merged commit d984090 into nuxtlabs:main Aug 29, 2022
@stafyniaksacha stafyniaksacha deleted the fix/node-modules-components branch August 29, 2022 14:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with components from node_modules
2 participants