Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add 'neovim' to default labels if empty #14

Open
teto opened this issue Feb 22, 2023 · 2 comments
Open

add 'neovim' to default labels if empty #14

teto opened this issue Feb 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@teto
Copy link
Member

teto commented Feb 22, 2023

I suppose here :

if not args.labels or #args.labels == 0 then

This way most neovim plugins using this action could eventually come up at https://luarocks.org/labels/neovim
(once luarocks/luarocks-site#188 is fixed).

@mrcjkb
Copy link
Member

mrcjkb commented Feb 22, 2023

🤔 I would like to keep this compatible with non-neovim packages, if possible. So perhaps just adding neovim as a default label in action.yaml would be better - so it can be disabled if unwanted.

@teto
Copy link
Member Author

teto commented Feb 22, 2023

I would like to keep this compatible with non-neovim packages

Makes sense, I had not realized that (considerign the orgname maybe "nvim-neorocks" ;) ). Also the scripts picks up the repository labels, which should probably contain "neovim", so maybe it's just a matter of adding it to the doc or have an heuristic that detects the repo is a neovim plugin and warns the user to set "neovim" as a repo label when missing.

@mrcjkb mrcjkb added the enhancement New feature or request label Jul 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants