Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Single source of truth for luarocks test dependencies #57

Open
mrcjkb opened this issue Jun 13, 2023 · 2 comments
Open

Single source of truth for luarocks test dependencies #57

mrcjkb opened this issue Jun 13, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mrcjkb
Copy link
Member

mrcjkb commented Jun 13, 2023

To run luarocks test locally (without nix), package maintainers have to add a rockspec that lists test_dependencies to the repository root (if the project has dependencies).

(See my blog post)

With the github action, this is means we have two sources of truth.
We should come up with a way to have only one source of truth (e.g. a script that generates a rockspec based on the github actions workflow yaml).

@mrcjkb mrcjkb added the enhancement New feature or request label Jul 16, 2023
@mrcjkb mrcjkb self-assigned this Sep 15, 2023
@mrcjkb
Copy link
Member Author

mrcjkb commented Sep 15, 2023

This should be solvable by using the same core generation logic, and generating a <package>-scm-1.rockspec with test dependencies added if they have not been set.

@mrcjkb
Copy link
Member Author

mrcjkb commented Sep 15, 2023

It might still be useful for people to have an scm rockspec in the project root, e.g. for local and nix test runs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant