Skip to content

Commit 07253ec

Browse files
committed
[actions] adjust shellcheck/windows tests to9 have a final "done" job
1 parent f258227 commit 07253ec

File tree

2 files changed

+20
-5
lines changed

2 files changed

+20
-5
lines changed

.github/workflows/shellcheck.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: 'Tests: shellcheck'
33
on: [pull_request, push]
44

55
jobs:
6-
shellcheck:
6+
shellcheck_matrix:
77
runs-on: ubuntu-latest
88
strategy:
99
matrix:
@@ -29,3 +29,9 @@ jobs:
2929
- run: "shellcheck --version"
3030
- name: Run shellcheck on ${{ matrix.file }}
3131
run: shellcheck -s ${{ matrix.shell }} ${{ matrix.file }}
32+
33+
shellcheck:
34+
needs: [shellcheck_matrix]
35+
runs-on: ubuntu-latest
36+
steps:
37+
- run: 'echo tests completed'

.github/workflows/windows-npm.yml

+13-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ env:
77
NVM_INSTALL_VERSION: ${{ github.sha }}
88

99
jobs:
10-
node_fail_install:
10+
msys_fail_install:
1111
# Default installation does not work due to npm_config_prefix set to C:\npm\prefix
1212
name: 'MSYS fail prefix nvm install'
1313
runs-on: windows-latest
@@ -18,7 +18,8 @@ jobs:
1818
curl -fsSLo- "https://raw.githubusercontent.com/${NVM_INSTALL_GITHUB_REPO}/${NVM_INSTALL_VERSION}/install.sh" | METHOD=script bash
1919
. "$HOME/.nvm/nvm.sh"
2020
! nvm install --lts
21-
nodes:
21+
22+
msys_matrix:
2223
name: 'MSYS nvm install'
2324
runs-on: windows-latest
2425
strategy:
@@ -39,7 +40,8 @@ jobs:
3940
fi
4041
. "$HOME/.nvm/nvm.sh"
4142
nvm install ${{ matrix.npm-node-version }}
42-
node_cygwin:
43+
44+
cygwin_matrix:
4345
name: 'Cygwin nvm install'
4446
runs-on: windows-latest
4547
steps:
@@ -75,7 +77,8 @@ jobs:
7577
run: |
7678
cd %USERPROFILE%\cygwin\bin
7779
bash.exe "%USERPROFILE%\setup.sh"
78-
wsl_nodes:
80+
81+
wsl_matrix:
7982
name: 'WSL nvm install'
8083
runs-on: windows-latest
8184
env:
@@ -104,3 +107,9 @@ jobs:
104107
fi
105108
. "$HOME/.nvm/nvm.sh"
106109
nvm install ${{ matrix.npm-node-version }}
110+
111+
nvm_windows:
112+
needs: [wsl_matrix, cygwin_matrix, msys_matrix, msys_fail_install]
113+
runs-on: ubuntu-latest
114+
steps:
115+
- run: 'echo tests completed'

0 commit comments

Comments
 (0)