Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Issue] Outfox integration : SOCKS5 proxy ignore outfox flag in config file #3972

Open
simonwicky opened this issue Oct 9, 2023 · 2 comments
Assignees
Labels
bug Something isn't working bug-needs-triage A bug that needs discussing and triage needs-triage qa Quality Assurance

Comments

@simonwicky
Copy link
Contributor

Describe the issue
A SOCKS5 proxy with packet_type = 'outfox' in the config file will still send sphinx packets.

Expected behaviour
Without any overriding instructions, a SOCKS5 proxy with such a config file should send outfox packets.

Steps to Reproduce
Set up a SOCKS5 proxy with packet_type = 'outfox', and route traffic through it. The debug log will display Sphinx packets being sent.

Issue cause
The run command from the SOCKS5 proxy accepts an --outfox flag. Its presence will cause the config to be overridden and to send outfox packets, which is expected. However, its absence will also cause a config override, and sphinx packets will be sent. This behaviour is not expected and very counter intuitive.

@simonwicky simonwicky added bug Something isn't working bug-needs-triage A bug that needs discussing and triage qa Quality Assurance needs-triage labels Oct 9, 2023
@durch
Copy link
Contributor

durch commented Oct 12, 2023

We don't seem to have any traffic related properties in the config file, so the package_type in config is not supposed to work, the question is, do we want to add these to the config? cc @mmsinclair , @simonwicky

@simonwicky
Copy link
Contributor Author

We can already set Poisson process delays, mixing delays, SURBs and cover traffic use in the config file. At least for me, it was really practical to be able to set the packet type in the config file as well.
Note that it already works on the native client and the network requester, since it does not have the --outfox CLI argument.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working bug-needs-triage A bug that needs discussing and triage needs-triage qa Quality Assurance
Projects
None yet
Development

No branches or pull requests

4 participants