Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Naming/location of Node struct #20

Open
futurechimp opened this issue Nov 29, 2019 · 0 comments
Open

Naming/location of Node struct #20

futurechimp opened this issue Nov 29, 2019 · 0 comments

Comments

@futurechimp
Copy link
Contributor

The Node struct is currently in a weird location in the code. When using it from the nym-client I'm currently building, errors point to very misleading file location:

error[E0277]: `sphinx::route::Node` doesn't implement `std::fmt::Debug`
  --> src/clients/directory.rs:49:9
   |
49 |         assert_eq!(expected, mixes.as_slice());
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `sphinx::route::Node` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`

I look in /header/routing/nodes.rs (which I can see in my file tree) but it's not there. It seems to be living in /route.rs.

What is the difference between these two locations? Can we name things a bit better to make the differences clearer?

@mmsinclair mmsinclair moved this to To analyse in Core systems May 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
No open projects
Status: To analyse
Development

No branches or pull requests

1 participant