Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Astro support #1189

Open
1 task done
v36u opened this issue Oct 17, 2023 · 4 comments · May be fixed by #1317
Open
1 task done

Astro support #1189

v36u opened this issue Oct 17, 2023 · 4 comments · May be fixed by #1317
Labels
enhancement New feature or request good first issue Good for newcomers upstream

Comments

@v36u
Copy link

v36u commented Oct 17, 2023

Language Name 🖊

The name of the framework is "Astro".

Official docs: https://docs.astro.build/

Not mentioned in the README, but it seems that tokei supports Astro: https://github.com/XAMPPRocky/tokei/blob/c8e4d0703252c87b1df45382b365c6bb00769dbe/languages.json#L85-L89

Logo 📷

White "A": https://astro.js.org/astro.png
Black "A": https://raw.githubusercontent.com/github/explore/5cc0a03a302ec862c4aeac2a22a513ae31c35432/topics/astro/astro.png

Upstream support ✅

  • Does tokei already support the language in question?
@v36u v36u added enhancement New feature or request good first issue Good for newcomers labels Oct 17, 2023
@spenserblack
Copy link
Collaborator

spenserblack commented Oct 17, 2023

The latest release of tokei was a pre-release 7 months ago. Astro was added 6 months ago (XAMPPRocky/tokei@fb2a612), so I'll mark this as an upstream issue for now.

Also, see these issues/PRs 😉

@spenserblack
Copy link
Collaborator

Off-topic: @o2sh How do you feel about using a tokei pre-release? With 13.0.0-alpha.0 I think we could merge #940 and #523

@o2sh
Copy link
Owner

o2sh commented Oct 21, 2023

I'd be cautious about using a pre-release version for such an important feature, especially considering tokei's slow update schedule. If we need fixes, it might take a while 😓 .

@EliasLeguizamon123
Copy link

Hi, i try to fix this with #1317

@spenserblack spenserblack linked a pull request Apr 24, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants