Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

New lint: pub fn stops being const #190

Closed
Tracked by #5
obi1kenobi opened this issue Nov 23, 2022 · 0 comments · Fixed by #224
Closed
Tracked by #5

New lint: pub fn stops being const #190

obi1kenobi opened this issue Nov 23, 2022 · 0 comments · Fixed by #224
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Nov 23, 2022 •
edited
Loading

If a public function stops being const, that's a breaking change: uses of that function in const contexts will no longer be allowed.

We already have the necessary schema for this, so this just needs the lint query and a test case.
@obi1kenobi obi1kenobi mentioned this issue Nov 23, 2022
Open
@obi1kenobi obi1kenobi changed the title pub fn stops being const New lint: pub fn stops being const Nov 23, 2022
@obi1kenobi obi1kenobi added A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Nov 23, 2022
@obi1kenobi obi1kenobi mentioned this issue Dec 17, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lints for removing const from functions and methods. obi1kenobi/cargo-semver-checks
1 participant
@obi1kenobi