New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

New lint: trait becomes `unsafe` #231

Closed

Tracked by

obi1kenobi opened this issue Dec 19, 2022 · 0 comments

Closed

Tracked by

New lint: trait becomes `unsafe` #231

obi1kenobi opened this issue Dec 19, 2022 · 0 comments

Assignees

Labels

A-lint E-help-wanted E-mentor

Owner

obi1kenobi commented Dec 19, 2022 •

edited

Loading

Implementing an unsafe trait requires an unsafe impl block, which is a breaking change: https://doc.rust-lang.org/book/ch19-01-unsafe-rust.html#implementing-an-unsafe-trait

Needs schema additions to expose whether the trait is unsafe:
https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc_json_types/struct.Trait.html
https://github.com/obi1kenobi/trustfall-rustdoc-adapter/blob/0b1f021c22aab6e48f38156e52c7b8331447149a/src/rustdoc_schema.graphql#L382

The text was updated successfully, but these errors were encountered:

obi1kenobi mentioned this issue

Tracking issue: Additional checks, both semver and non-semver #5

Open

obi1kenobi added A-lint C-enhancement E-help-wanted E-mentor and removed C-enhancement labels

obi1kenobi changed the title ~~trait becomes unsafe~~ New lint: trait becomes unsafe

obi1kenobi mentioned this issue

Tracking issue: Required schema additions to make new lints possible #241

Open

11 tasks

obi1kenobi mentioned this issue

New lint: unsafe trait becomes safe #250

Closed

staniewzki self-assigned this

staniewzki closed this as completed

# for free to join this conversation on GitHub. Already have an account? # to comment