Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New lint: trait item removed #368

Closed
Tracked by #5
whentze opened this issue Feb 15, 2023 · 1 comment · Fixed by #427
Closed
Tracked by #5

New lint: trait item removed #368

whentze opened this issue Feb 15, 2023 · 1 comment · Fixed by #427
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@whentze
Copy link

whentze commented Feb 15, 2023

Going from

pub trait Foo {
  fn foo();
}

to

pub trait Foo {
}

is a breaking change. There should be a lint for that.

@obi1kenobi obi1kenobi added A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Feb 15, 2023
@obi1kenobi
Copy link
Owner

Agreed, thanks for opening this! If you're interested in adding this lint, I'd be happy to mentor and I think it should be fairly straightforward to do.

It depends on obi1kenobi/trustfall-rustdoc-adapter#85 which is also fairly straightforward, completely analogous to existing code.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants