Skip to content

Plot.boxX default fill should be responsive with dark mode #2006

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
Fil opened this issue Feb 28, 2024 · 0 comments
Open

Plot.boxX default fill should be responsive with dark mode #2006

Fil opened this issue Feb 28, 2024 · 0 comments
Labels
enhancement New feature or request question Further information is needed

Comments

@Fil
Copy link
Contributor

Fil commented Feb 28, 2024

The default fill for boxX is #ccc, which is way too light in dark mode (when --plot-background is dark and currentColor is light).

Should we address this by "hardcoding" a new color in box.js, say color-mix(in oklab, var(--plot-background), currentColor 80%), or by introducing an intermediate --color80?
The only other "hardcoded" colors are

  • stroke = "#555" in treeLink (which would be --color33 in my scheme)
  • positiveFill = "#3ca951", negativeFill = "#4269d0", in differenceY (but that one is ok I think)
@Fil Fil added enhancement New feature or request question Further information is needed labels Feb 28, 2024
@Fil Fil mentioned this issue Aug 12, 2024
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request question Further information is needed
Projects
None yet
Development

No branches or pull requests

1 participant