Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New opam release #6

Open
Firobe opened this issue Nov 14, 2022 · 3 comments
Open

New opam release #6

Firobe opened this issue Nov 14, 2022 · 3 comments
Assignees

Comments

@Firobe
Copy link

Firobe commented Nov 14, 2022

We should:

  • update the current version package with a dune < 3 constraint
  • release a new opam version of the orun package that includes the now merged refactor: move binary to own dir #4 PR without that constraint, e.g. that can be used by sandmark without needing pins
@ElectreAAS
Copy link
Contributor

@shakthimaan I assigned this issue to you so we can avoid another specific pin in sandmark, and just use the latest opam version

@shakthimaan
Copy link
Contributor

update the current version package with a dune < 3 constraint

Now that we are using dune.3.5.0 for 5.1.0+trunk, the constraint is no longer required?

@Firobe
Copy link
Author

Firobe commented Feb 8, 2023

The problem was:

  • the package currently released on opam breaks if using a dune version > 3. No matter what we should push a revision for that version to forbid dune > 3 so that opam rejects that version when a newer dune is installed
  • there is no release on opam for the current development version, so a pin is needed for sandmark. To avoid that, the current dev branch should be released as a new version of the opam package

I don't think the usage of dune 3 in sandmark changes that, but these are pretty minor problems if sandmark is the only place where orun is used.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants