Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Complete the move to ocaml-community #55

Open
5 of 6 tasks
paurkedal opened this issue Aug 9, 2024 · 10 comments
Open
5 of 6 tasks

Complete the move to ocaml-community #55

paurkedal opened this issue Aug 9, 2024 · 10 comments

Comments

@paurkedal
Copy link
Collaborator

paurkedal commented Aug 9, 2024

This is the checklist from https://github.com/ocaml-community/meta, reordered:

  • The code should be updated so that it compiles and runs on the latest version of OCaml.
  • An OPAM package should be created and submitted for the package if one does not yet exist, or the existing package should be updated to point to the new repository location.
  • The new code owners should be placed into a CODEOWNERS file in the repository.
  • If feasible, older build systems should be converted to dune. (Switch to dune #51 or Switch build system to dune and dune-configurator. #52)
  • The repository should be carefully checked for references to old repository locations, home pages, maintainers, etc., and these references should be updated.
  • A .travis.yml file should be added to the repository and the CI system should be turned on by an administrator. Generally, builds should be tried on the latest several versions of OCaml, on both Linux and on MacOS.
@paurkedal
Copy link
Collaborator Author

@ygrek At the moment I assume you are the only admin for the repo, as I can't self-assign this issue or see the settings, so if we keep it that way, the .github/CODEOWNERS (I suggest we use that location since it takes precedence over the alternatives) should contain * @ygrek. I think I'll get the same notifications by subscribing to the project (but I can also be a owner if you also want help with merges and releases).

@ygrek
Copy link
Collaborator

ygrek commented Aug 9, 2024

no, I am not an admin
@andrenth must be as the owner before the transfer

@andrenth
Copy link
Collaborator

I can't see the settings either. I'll try to create the CODEOWNERS file.

@andrenth
Copy link
Collaborator

Done

@ygrek
Copy link
Collaborator

ygrek commented Aug 15, 2024

i see I am admin now, made @andrenth admin too and invited @paurkedal

@pmetzger
Copy link
Member

The travis bit in the checklist should be changed to github actions. You can look at some of the other ocaml-community projects for examples.

@paurkedal
Copy link
Collaborator Author

Thanks to both of you for sorting out access.

I would like to merge the dune support before adding GitHub Actions, to avoid debugging any CI issues related to the oasis setup. The CI will be a good opportunity to test if my ./configure conversion is really one-to-one as I claim, if we go for OS coverage, so I could start a new PR based on that PR (with some cross-fixing and rebasing).

Note that I'm off for a two-weeks vacation, so my contributions may be sporadic for the remainder of the month.

@pmetzger
Copy link
Member

It's up to you guys what order you do stuff in.

@paurkedal
Copy link
Collaborator Author

I updated the URLs in the OPAM file. @ygrek, can you update the maintainer field, assuming you plan on doing the releases?

@ygrek
Copy link
Collaborator

ygrek commented Nov 26, 2024

(as discussed elsewhere i don't plan to, so please update as you see fit)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants