merged

Author: jvanburen

.github/workflows/selection.yml

@@ -0,0 +1,35 @@
+name: Selection changes reminder
+
+on:
+  pull_request_target:
+    types: [opened, synchronize, reopened]
+    paths:
+      - 'backend/selectgen.ml'
+      - 'backend/arm64/selection.ml'
+      - 'backend/amd64/selection.ml'
+
+jobs:
+  remind:
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Create PR Comment
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          REPO=${{ github.repository }}
+          PR_NUMBER=${{ github.event.pull_request.number }}
+          COMMENT="## Selection Change Check
+
+          This PR modifies the original selection pass (targeting Mach).
+          Please check whether the changes should also be applied to the
+          CFG variant of the pass."
+
+           # Check if comment already exists
+          if ! gh pr view $PR_NUMBER --json comments -q '.comments[].body' --repo $REPO | grep -q "Selection Change Check"; then
+            gh pr comment $PR_NUMBER --body "$COMMENT" --repo $REPO
+            echo "Comment added successfully."
+          else
+            echo "Comment already exists. Skipping."
+          fi

lambda/lambda.ml

@@ -2224,9 +2224,9 @@ let primitive_result_layout (p : primitive) =
   | Paddfloat (f, _) | Psubfloat (f, _) | Pmulfloat (f, _) | Pdivfloat (f, _)
   | Pbox_float (f, _) -> layout_boxed_float f
   | Pufloatfield _ -> Punboxed_float Unboxed_float64
-  | Punbox_float f -> layout_unboxed_float (Primitive.unbox_float f)
+  | Punbox_float f -> layout_unboxed_float (Primitive.unboxed_float f)
   | Pbox_vector (v, _) -> layout_boxed_vector v
-  | Punbox_vector v -> layout_unboxed_vector (Primitive.unbox_vector v)
+  | Punbox_vector v -> layout_unboxed_vector (Primitive.unboxed_vector v)
   | Pmixedfield (_, kind, _, _) -> layout_of_mixed_field kind
   | Pccall { prim_native_repr_res = _, repr_res } -> layout_of_extern_repr repr_res
   | Praise _ -> layout_bottom
@@ -2257,7 +2257,7 @@ let primitive_result_layout (p : primitive) =
     layout_boxed_int bi
   | Ptag_int _ -> layout_int
   | Puntag_int i -> layout_unboxed_int i
-  | Punbox_int bi -> Punboxed_int (Primitive.unbox_integer bi)
+  | Punbox_int bi -> Punboxed_int (Primitive.unboxed_integer bi)
   | Pstring_load_32 { boxed = true; _ } | Pbytes_load_32 { boxed = true; _ }
   | Pbigstring_load_32 { boxed = true; _ } ->
     layout_boxed_int Boxed_int32

middle_end/flambda2/from_lambda/lambda_to_flambda_primitives.ml

@@ -114,7 +114,7 @@ let standard_int_or_float_of_unboxed_integer (ubint : L.unboxed_integer) :
   | Unboxed_int64 -> Naked_int64
 
 let standard_int_or_float_of_boxed_integer bint =
-  standard_int_or_float_of_unboxed_integer (Primitive.unbox_integer bint)
+  standard_int_or_float_of_unboxed_integer (Primitive.unboxed_integer bint)
 
 let convert_block_access_field_kind i_or_p : P.Block_access_field_kind.t =
   match i_or_p with L.Immediate -> Immediate | L.Pointer -> Any_value
@@ -1514,7 +1514,7 @@ let convert_lprim ~big_endian (prim : L.primitive) (args : Simple.t list list)
     [ tag_int
         (Binary
            ( convert_unboxed_integer_comparison_prim
-               (Primitive.unbox_integer kind)
+               (Primitive.unboxed_integer kind)
                comp,
              arg1,
              arg2 )) ]