Skip to content

Delete unused x87 FP operations from amd64 backend #1555

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

TheNumbat
Copy link
Contributor

@TheNumbat TheNumbat commented Jul 11, 2023

We do not use the x87 floating point instructions on modern x86_64 CPUs, so this PR removes them.
This change allows the SIMD PR (#1499) to use the same register type regf for representing XMM regs.

The operations are not removed from the upstream backend (ocaml/backend).

@TheNumbat TheNumbat marked this pull request as ready for review July 11, 2023 18:36
@xclerc xclerc added backend non-material change Formatting, renaming, etc. but no semantic or public API changes internal-assembler and removed non-material change Formatting, renaming, etc. but no semantic or public API changes labels Jul 12, 2023
@gretay-js
Copy link
Contributor

The operations are not removed from the upstream backend (ocaml/backend).

you probably mean ocaml/asmcomp.

@gretay-js gretay-js merged commit b66e9b2 into main Jul 12, 2023
@TheNumbat TheNumbat deleted the remove-x87 branch July 12, 2023 17:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants