Skip to content

Copy Import_info as Import_info.Intf and Import_info.Impl #1933

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 7 commits into from

Conversation

lukemaurer
Copy link
Contributor

PR #1746 will change the APIs and implementations to reflect the differences in the datatypes. (Currently, the major difference is that an Impl.t always has a full compilation unit, but parameterised libraries will add more differences.)

PR oxcaml#1746 will change the APIs and implementations to reflect the differences in
the datatypes. (Currently, the major difference is that an `Impl.t` always has a
full compilation unit, but parameterised libraries will add more differences.)
@lukemaurer lukemaurer marked this pull request as draft April 29, 2024 17:23
@lukemaurer
Copy link
Contributor Author

Converting to draft, as this work may be getting rolled into #1753 .

@lukemaurer
Copy link
Contributor Author

Converting to draft, as this work may be getting rolled into #1753 .

(or at any rate this PR's direction may be influenced by that one)

lukemaurer added a commit to lukemaurer/flambda-backend that referenced this pull request Apr 30, 2024
[Import_info.t] is now split between the intf and impl cases, which will make it
easier for a subsequent PR (which will likely supersede oxcaml#1746 and oxcaml#1933) to pull
apart the types and force all callers to choose.

Also added a [Consistbl]-centric API for each of [Intf] and [Impl] to make it
easy again to convert between import info and an entry in a [Consistbl].
@mshinwell mshinwell added the parameterized-libs PRs needed for parameterized libraries label May 1, 2024
@lukemaurer
Copy link
Contributor Author

Superseded by #2552.

@lukemaurer lukemaurer closed this May 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
parameterized-libs PRs needed for parameterized libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants