Replace ocaml.1 with ocaml_1 in provider name for stapsdt elf notes #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like some versions of perf parse provider expecting it to have syntax of a C function name, i.e., dots are not allowed.
xclerc
approved these changes
May 4, 2022
mshinwell
pushed a commit
that referenced
this pull request
May 20, 2022
…638) Looks like some versions of perf parse provider expecting it to have syntax of a C function name, i.e., dots are not allowed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We piggyback on the provider field of stapsdt elf notes to indicate the version of ocaml-probes. (The experiemental mechanism for enabling ocaml-probes is separate from systemtap and subject to change so it was useful to have a version number, see #60 (comment).)
Looks like
perfparses the provider field of stapsdt elf notes expecting its syntax to be a C symbol name (i.e., dots are not allowed). For example, iftest.exehas any ocaml-probes, thenperf record test.exesometimes prints this warning:It seems to generate
perf.datajust fine if we don't use these probes with -e.Thanks @Xyene for reporting this issue.