Remove glpk warnings and strengthen mccs code #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Can you separate into 2 PRs, one for whitespaces, another fro compilation fixes ? |
Done, whitespace removal is now #46. |
|
Some of the warnings raised will be fixed in an upcoming version of glpk. |
and not a toplevel file. Helps with Dune/merlin integration.
The former are deprecated, the second are more secure because they bound-check where they write.
kit-ty-kate
changed the title
kit-ty-kate
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Instead of trying to detect the current C compiler i changed the code to simply disable every warnings in glpk as it's not section of the code we (should) change given it is a simple vendor. The previous version with -Wall would show a wall off warnings that we wouldn't be able to fix.
LGTM now
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.