Skip to content

Commit 059fbf2

Browse files
authored
Merge pull request #51 from ocaml-wasm/binaryen-118
Switch to Binaryen 118
2 parents 4b0706c + d5e9b95 commit 059fbf2

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

Diff for: .github/workflows/build-wasm_of_ocaml.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ jobs:
3131
- name: Install node
3232
uses: actions/setup-node@v4
3333
with:
34-
node-version: v22.0.0-v8-canary2024030314ed92e804
34+
node-version: 22
3535

3636
- name: Restore cached binaryen
3737
id: cache-binaryen
3838
uses: actions/cache/restore@v4
3939
with:
4040
path: binaryen
41-
key: ${{ runner.os }}-binaryen-version_117
41+
key: ${{ runner.os }}-binaryen-version_118
4242

4343
- name: Checkout binaryen
4444
if: steps.cache-binaryen.outputs.cache-hit != 'true'
@@ -47,7 +47,7 @@ jobs:
4747
repository: WebAssembly/binaryen
4848
path: binaryen
4949
submodules: true
50-
ref: version_117
50+
ref: version_118
5151

5252
- name: Install ninja
5353
if: steps.cache-binaryen.outputs.cache-hit != 'true'
@@ -65,7 +65,7 @@ jobs:
6565
uses: actions/cache/save@v4
6666
with:
6767
path: binaryen
68-
key: ${{ runner.os }}-binaryen-version_117
68+
key: ${{ runner.os }}-binaryen-version_118
6969

7070
- name: Set binaryen's path
7171
run: |

Diff for: README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ Wasm_of_ocaml is a fork of Js_of_ocaml which compiles OCaml bytecode to WebAssem
44

55
## Requirements
66

7-
Wasm_of_ocaml relies on the Binaryen toolchain; currently, only [version 117](https://github.com/WebAssembly/binaryen/releases/tag/version_117) is supported. Binaryen commands must be in the PATH for wasm_of_ocaml to function.
7+
Wasm_of_ocaml relies on the Binaryen toolchain; currently, only versions [118](https://github.com/WebAssembly/binaryen/releases/tag/version_118) or greater are supported. Binaryen commands must be in the PATH for wasm_of_ocaml to function.
88

99
## Supported engines
1010

11-
The generated code works with Chrome 11.9, [node V8 canary](https://nodejs.org/download/v8-canary/v21.0.0-v8-canary20230927fa59f85d60/) and [Firefox 122](https://www.mozilla.org/en-US/firefox/new/).
11+
The generated code works with Chrome 11.9, Node.js 22 and Firefox 122 (or more recent versions of these applications).
1212

1313
In particular, the output code requires the following [Wasm extensions](https://webassembly.org/roadmap/) to run:
1414
- [the GC extension](https://github.com/WebAssembly/gc), including functional references and 31-bit integers

Diff for: runtime/wasm/dune

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
(system
1414
"which wasm-merge > /dev/null || (echo 'Error: Binaryen tools not found in the PATH'; false)")
1515
(system
16-
"wasm-merge --version | grep -q 'version 117' || (echo 'Error: Binaryen version 117 is currently required'; false)")
16+
"wasm-merge --version | grep -q 'version \\(11[789]\\|1[2-9][0-9]\\)' || (echo 'Error: Binaryen version 117 or greater is currently required'; false)")
1717
(pipe-stdout
1818
(run
1919
wasm-merge

0 commit comments

Comments
 (0)