Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[feature request] 'deprecated' flag #4522

Closed
kit-ty-kate opened this issue Feb 4, 2021 · 4 comments · Fixed by #4523
Closed

[feature request] 'deprecated' flag #4522

kit-ty-kate opened this issue Feb 4, 2021 · 4 comments · Fixed by #4523
Assignees
Milestone

Comments

@kit-ty-kate
Copy link
Member

A builtin support in opam for a deprecated flag would be nice. Here what such flag would do:

  • Any packages flagged with deprecated would be avoided by the solver unless there is no other choice (e.g. some user wants to install package a which depends on b which is deprecated)
  • If it is installed, show up a note after installation notifying the user that the package is deprecated. If the developer deprecating the package wants to add precisions, they can do it using the post-messages field as it was already done for such a purpose.

Related to ocurrent/opam-health-check#8

@dbuenzli
Copy link
Contributor

dbuenzli commented Feb 4, 2021

Related to #2046

@AltGr
Copy link
Member

AltGr commented Feb 4, 2021

There is a significant overlap with hidden-version (which we haven't renamed yet it seems ?) here;

@dra27
Copy link
Member

dra27 commented Feb 4, 2021

I think it would implemented internally as hidden-version - the difference is just the extra messages, I think?

@kit-ty-kate
Copy link
Member Author

kit-ty-kate commented Feb 4, 2021

Implemented in #4523

I think it would implemented internally as hidden-version - the difference is just the extra messages, I think?

The differences are:

  • the name: which is going to be used by external tools (e.g. opam-health-check). For that purpose only we most likely want to differenciate the two.
  • upgrades of a deprecated package is not forbidden as it is with hidden-version
  • the extra message

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants