Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix opam admin check --obsolete #5805

Open
kit-ty-kate opened this issue Jan 24, 2024 · 1 comment
Open

Fix opam admin check --obsolete #5805

kit-ty-kate opened this issue Jan 24, 2024 · 1 comment

Comments

@kit-ty-kate
Copy link
Member

As noted in #5748, opam admin check --obsolete currently doesn’t work for its intended purpose.

Instead of ignoring available and filters (I haven’t looked at the code, I’m just guessing based on behaviour) it should probably:

  • for each packages
    • list all variables they’re using
      • for each uses call the solver with the variable set to the possible values (the tricky part)
      • add all those possibilities to the result

This should also probably get rid of the need to have a --ignore-test-doc argument.
This could also fix #4541 since it’s sharing some code

@kit-ty-kate
Copy link
Member Author

cc @Armael @gasche since you both worked on something similar in the past to try and fix #4541.
Sorry the pseudo algorithm is very handwavy, this is very much a back of a napkin type thing and I’m not sure if the third point is even possible in particular, i think it’s probably too tricky to do precisely but an heuristic when you just evaluate all expression to true and false then solve N-time seems fine. Do you have any insights by any chance?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant