Skip to content

Commit 587caa8

Browse files
committed
Refactor use of changedir in tox.ini (open-telemetry#2332)
Fixes #3745
1 parent 565e78d commit 587caa8

File tree

5 files changed

+81
-23
lines changed

5 files changed

+81
-23
lines changed

instrumentation/opentelemetry-instrumentation-elasticsearch/pyproject.toml

-5
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,6 @@ dependencies = [
3434
instruments = [
3535
"elasticsearch >= 2.0",
3636
]
37-
test = [
38-
"opentelemetry-instrumentation-elasticsearch[instruments]",
39-
"elasticsearch-dsl >= 2.0",
40-
"opentelemetry-test-utils == 0.45b0.dev",
41-
]
4237

4338
[project.entry-points.opentelemetry_instrumentor]
4439
elasticsearch = "opentelemetry.instrumentation.elasticsearch:ElasticsearchInstrumentor"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
Deprecated==1.2.14
4+
elasticsearch==2.4.1
5+
elasticsearch-dsl==2.2.0
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
packaging==23.2
9+
pluggy==1.4.0
10+
py==1.11.0
11+
py-cpuinfo==9.0.0
12+
pytest==7.1.3
13+
pytest-benchmark==4.0.0
14+
python-dateutil==2.8.2
15+
six==1.16.0
16+
tomli==2.0.1
17+
typing_extensions==4.10.0
18+
urllib3==1.26.18
19+
wrapt==1.16.0
20+
zipp==3.17.0
21+
-e opentelemetry-instrumentation
22+
-e instrumentation/opentelemetry-instrumentation-elasticsearch
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
Deprecated==1.2.14
4+
elasticsearch==5.5.3
5+
elasticsearch-dsl==5.4.0
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
packaging==23.2
9+
pluggy==1.4.0
10+
py==1.11.0
11+
py-cpuinfo==9.0.0
12+
pytest==7.1.3
13+
pytest-benchmark==4.0.0
14+
python-dateutil==2.8.2
15+
six==1.16.0
16+
tomli==2.0.1
17+
typing_extensions==4.10.0
18+
urllib3==2.2.1
19+
wrapt==1.16.0
20+
zipp==3.17.0
21+
-e opentelemetry-instrumentation
22+
-e instrumentation/opentelemetry-instrumentation-elasticsearch
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
Deprecated==1.2.14
4+
elasticsearch==6.8.2
5+
elasticsearch-dsl==6.4.0
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
packaging==23.2
9+
pluggy==1.4.0
10+
py==1.11.0
11+
py-cpuinfo==9.0.0
12+
pytest==7.1.3
13+
pytest-benchmark==4.0.0
14+
python-dateutil==2.8.2
15+
six==1.16.0
16+
tomli==2.0.1
17+
typing_extensions==4.10.0
18+
urllib3==2.2.1
19+
wrapt==1.16.0
20+
zipp==3.17.0
21+
-e opentelemetry-instrumentation
22+
-e instrumentation/opentelemetry-instrumentation-elasticsearch

tox.ini

+15-18
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,16 @@ envlist =
6767
; pypy3-test-instrumentation-boto
6868

6969
; opentelemetry-instrumentation-elasticsearch
70-
py3{8,9,10,11}-test-instrumentation-elasticsearch-{2,6}
71-
pypy3-test-instrumentation-elasticsearch-{2,6}
72-
py3{8,9}-test-instrumentation-elasticsearch-5
73-
pypy3-test-instrumentation-elasticsearch-5
70+
; FIXME: Elasticsearch >=7 causes CI workflow tests to hang, see open-telemetry/opentelemetry-python-contrib#620
71+
; The numbers at the end of the environment names
72+
; below mean these dependencies are being used:
73+
; 0: elasticsearch-dsl>=2.0,<3.0 elasticsearch>=2.0,<3.0
74+
; 1: elasticsearch-dsl>=5.0,<6.0 elasticsearch>=5.0,<6.0
75+
; 2: elasticsearch-dsl>=6.0,<7.0 elasticsearch>=6.0,<7.0
76+
py3{8,9,10,11}-test-instrumentation-elasticsearch-{0,2}
77+
pypy3-test-instrumentation-elasticsearch-{0,2}
78+
py3{8,9}-test-instrumentation-elasticsearch-1
79+
pypy3-test-instrumentation-elasticsearch-1
7480

7581
; opentelemetry-instrumentation-falcon
7682
; py310 does not work with falcon 1
@@ -258,17 +264,6 @@ deps =
258264
django-2: django~=2.0
259265
django-3: django~=3.0
260266
django-4: django>=4.0b1,<5.0
261-
elasticsearch-2: elasticsearch-dsl>=2.0,<3.0
262-
elasticsearch-2: elasticsearch>=2.0,<3.0
263-
elasticsearch-5: elasticsearch-dsl>=5.0,<6.0
264-
elasticsearch-5: elasticsearch>=5.0,<6.0
265-
elasticsearch-6: elasticsearch-dsl>=6.0,<7.0
266-
elasticsearch-6: elasticsearch>=6.0,<7.0
267-
; FIXME: Elasticsearch >=7 causes CI workflow tests to hang, see open-telemetry/opentelemetry-python-contrib#620
268-
; elasticsearch-7: elasticsearch-dsl>=7.0,<8.0
269-
; elasticsearch-7: elasticsearch>=7.0,<8.0
270-
; elasticsearch-8: elasticsearch-dsl>=8.0,<9.0
271-
; elasticsearch-8: elasticsearch>=8.0,<9.0
272267
falcon-1: falcon ==1.4.1
273268
falcon-2: falcon >=2.0.0,<3.0.0
274269
falcon-3: falcon >=3.0.0,<4.0.0
@@ -416,7 +411,9 @@ commands_pre =
416411

417412
sqlalchemy-{11,14}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy[test]
418413

419-
elasticsearch-{2,5,6}: pip install {toxinidir}/opentelemetry-instrumentation[test] {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch[test]
414+
elasticsearch-0: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-0.txt
415+
elasticsearch-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-1.txt
416+
elasticsearch-2: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-2.txt
420417

421418
asyncio: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncio[test]
422419

@@ -451,7 +448,7 @@ commands =
451448
test-instrumentation-celery: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-celery/tests {posargs}
452449
test-instrumentation-dbapi: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-dbapi/tests {posargs}
453450
test-instrumentation-django-{1,2,3,4}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-django/tests {posargs}
454-
test-instrumentation-elasticsearch-{2,5,6}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/tests {posargs}
451+
test-instrumentation-elasticsearch-{0,1,2}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/tests {posargs}
455452
test-instrumentation-falcon-{1,2,3}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-falcon/tests {posargs}
456453
test-instrumentation-fastapi: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-fastapi/tests {posargs}
457454
test-instrumentation-flask-{213,220,300}: pytest {toxinidir}/instrumentation/opentelemetry-instrumentation-flask/tests {posargs}
@@ -574,7 +571,7 @@ commands_pre =
574571
# for your OS to install the required dependencies
575572
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-mysqlclient[test]
576573
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pymongo[test]
577-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch[test]
574+
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-2.txt
578575
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncpg[test]
579576
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-tornado[test]
580577
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-tortoiseorm[test]

0 commit comments

Comments
 (0)