fix: reject promise when calling 'load' instead of 'inject'

Fixes #147
ocombe · May 29, 2015 · 3159547 · 3159547
1 parent 499bd72
commit 3159547
Show file tree

Hide file tree

Showing 10 changed files with 34 additions and 10 deletions.
diff --git a/dist/modules/ocLazyLoad.loaders.core.js b/dist/modules/ocLazyLoad.loaders.core.js
@@ -114,7 +114,13 @@
                     promises.push(jsDeferred.promise);
                 }
 
-                if (params.serie && params.files.length > 0) {
+                if (promises.length === 0) {
+                    var deferred = $q.defer(),
+                        err = "Error: no file to load has been found, if you're trying to load an existing module you should use the 'inject' method instead of 'load'.";
+                    $delegate._$log.error(err);
+                    deferred.reject(err);
+                    return deferred.promise;
+                } else if (params.serie && params.files.length > 0) {
                     return $q.all(promises).then(function () {
                         return $delegate.filesLoader(config, params);
                     });

diff --git a/dist/ocLazyLoad.js b/dist/ocLazyLoad.js
diff --git a/dist/ocLazyLoad.js.map b/dist/ocLazyLoad.js.map
diff --git a/dist/ocLazyLoad.min.js b/dist/ocLazyLoad.min.js
diff --git a/dist/ocLazyLoad.min.js.map b/dist/ocLazyLoad.min.js.map
diff --git a/dist/ocLazyLoad.require.js b/dist/ocLazyLoad.require.js
diff --git a/dist/ocLazyLoad.require.js.map b/dist/ocLazyLoad.require.js.map
diff --git a/dist/ocLazyLoad.require.min.js b/dist/ocLazyLoad.require.min.js
diff --git a/dist/ocLazyLoad.require.min.js.map b/dist/ocLazyLoad.require.min.js.map
diff --git a/src/ocLazyLoad.loaders.core.js b/src/ocLazyLoad.loaders.core.js
@@ -109,7 +109,13 @@
                     promises.push(jsDeferred.promise);
                 }
 
-                if(params.serie && params.files.length > 0) {
+                if(promises.length === 0) {
+                    let deferred = $q.defer(),
+                        err = "Error: no file to load has been found, if you're trying to load an existing module you should use the 'inject' method instead of 'load'.";
+                    $delegate._$log.error(err);
+                    deferred.reject(err);
+                    return deferred.promise;
+                } else if(params.serie && params.files.length > 0) {
                     return $q.all(promises).then(() => $delegate.filesLoader(config, params));
                 } else {
                     return $q.all(promises).finally(res => {