Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for angular 1.4 #195

Closed
kschwidder opened this issue Jun 10, 2015 · 15 comments
Closed

Support for angular 1.4 #195

kschwidder opened this issue Jun 10, 2015 · 15 comments

Comments

@kschwidder
Copy link

Could you please provide support for 1.4 as it is out now and major libs are providing support for it.

@ocombe
Copy link
Owner

ocombe commented Jun 10, 2015

Well it's supposed to work, isn't it the case?

@kschwidder
Copy link
Author

Bower.json is not supporting 1.4.0. Please update bower file instead. Can than test it

@ocombe
Copy link
Owner

ocombe commented Jun 10, 2015

Well it does:
"angular": ">=1.2.x <=1.4.x"

Check it here: http://semver.npmjs.com/

@kschwidder
Copy link
Author

This is what I get from bower install:
Unable to find a suitable version for angular, please choose one:
1) angular#>=1.2.x <=1.4.x which resolved to 1.3.16 and is required by oclazyload#1.0.1

@ocombe
Copy link
Owner

ocombe commented Jun 11, 2015

Did you clean your bower cache ? bower cache clean
Also, maybe you have another bower module that is defined as 1.3.x and since ocLazyLoad is also compatible with this version it will take it?
And finally if that doesn't help you can add angular 1.4 as a dependency for your project and bower will select it since you manually defined it.

@kschwidder
Copy link
Author

I did the last one :-)
Your module is awesome !!! It works like a charm.

@ocombe
Copy link
Owner

ocombe commented Jun 11, 2015

Good. I'll take a look at this when I have the time, because it should be working with this expression.

@ocombe ocombe closed this as completed Jun 11, 2015
@ghost
Copy link

ghost commented Jul 31, 2015

Same issue for me.
All my dependencies are resolved to angular 1.4.3 except ocLazyLoad who said:

  1. angular#>=1.2.x <=1.4.x which resolved to 1.3.17 and is required by oclazyload#1.0.4

In my bower.json I have this line :

    "angular": "~1.4.3",

and

    "oclazyload": "~1.0.4",

I executed the bower cache clean command but no effect.

Thanks for your help!

@ocombe ocombe reopened this Jul 31, 2015
@ocombe
Copy link
Owner

ocombe commented Jul 31, 2015

Well that's weird, because the semver expression is valid, bower may not follow the npm syntax properly... ?
I could probably change it to >=1.2.x, I'll do it in the next version

@ghost
Copy link

ghost commented Jul 31, 2015

OK !
Thanks for your prompt reply 😉

@estaub
Copy link

estaub commented Aug 5, 2015

Re-reporting same problem. I'd suggest that using 'x' in comparisons, as in "<=1.4.x", is unusual, at the very least. A brief search found no example of use or specification of how it would be interpreted, including at https://github.com/npm/node-semver . I'm a noob, though! If anyone needs a quick fix, e.g., for heroku deployment, add a "resolutions" section (a peer to "dependencies") to your project's bower.json, forcing what you need, e.g.:

  "resolutions": {
    "angular": "1.4.3"
  },

This will quell messages like

     1) angular#>=1.2.x <=1.4.x which resolved to 1.3.17 and is required by oclazyload#1.0.4

@sargin48
Copy link

Please support angular 1.4
i cant install ocLazyLoad

@ocombe
Copy link
Owner

ocombe commented Aug 20, 2015

Yes I'll be back from my holidays tomorrow, I'll do it this week end. Sorry
for the inconvenience.

@sargin48
Copy link

Thanks ocombe.

@ocombe ocombe closed this as completed in 3062640 Aug 23, 2015
@ocombe
Copy link
Owner

ocombe commented Aug 23, 2015

Ok I changed it to >=1.2.0, let me know if it works (once I released a new version)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants