Fix for loading a module with dependencies with the oc-lazy-load directive #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of having this merged? If you want another solution to the problem don't hesitate to ask and I'll try to implement it... |
|
I'm in holidays for 2 more weeks and a half, it will have to wait |
|
Everything looks fine, and it doesn't seem like it breaks anything :) |
ocombe
added a commit
that referenced
this pull request
Aug 28, 2015
fix: loading a module with dependencies with multiple oc-lazy-load directives
|
Great, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that happens when you try to inject into a page a module at more that one place using the oc-lazy-load directive. It only happens when the module you try to inject has some files dependencies declared.
I created a reduced test case in this Plunker: http://plnkr.co/edit/pAq7cneNylQmfCFHZV66
Not 100% sure if the solution is the best way to solve the problem nor if it will have some unwanted side effect. The unit tests pass successfully.