Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed *.d.ts variable name to match source code #17

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Fixed *.d.ts variable name to match source code #17

merged 1 commit into from
Feb 4, 2019

Conversation

k2snowman69
Copy link
Contributor

Looking at the source code looks like the variable should be installationId for getInstallationAccessTokenOptions not installation_id

Looking at the source code looks like the variable should be `installationId` for `getInstallationAccessTokenOptions` not `installation_id`
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks a a lot for the pull request 💐

@gr2m gr2m merged commit 806aa0f into octokit:master Feb 4, 2019
@k2snowman69
Copy link
Contributor Author

Thanks!

@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants