Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: revert dependency on @octokit/webhooks to v9 #297

Merged
merged 1 commit into from
Jun 27, 2022
Merged

fix: revert dependency on @octokit/webhooks to v9 #297

merged 1 commit into from
Jun 27, 2022

Conversation

wolfy1339
Copy link
Member

@octokit/webhooks dropped compatibility with NodeJS v10 and v12 (octokit/webhooks.js#555), and it was merged into this repo, without creating a new major release.

This reverts commit 635708c.

@wolfy1339 wolfy1339 added the bug label Jun 27, 2022
@wolfy1339 wolfy1339 linked an issue Jun 27, 2022 that may be closed by this pull request
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gr2m gr2m merged commit 1da972d into v12 Jun 27, 2022
@gr2m gr2m deleted the revert-294 branch June 27, 2022 19:51
@wolfy1339
Copy link
Member Author

I think semantic-release missed this one as it isn't in it's config.

@gr2m
Copy link
Contributor

gr2m commented Jun 27, 2022

oh I think it needs to be

BREAKING CHANGE:

not

BREAKING CHANGES:

Let me fix with an empty commit

gr2m pushed a commit that referenced this pull request Jun 27, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken node 10/12 compatibility
2 participants