[fix] Escape ref in archive_link
#1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com>
nickfloyd
approved these changes
May 24, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
archive_linkwith Unicode characters we have the following error:URI must be ascii only "repos/octokit/octokit.rb/tarball/\u{1F419}\u{1F431}"This PR fixes the issue with using
CGI.escapebut I am open to any other alternative, I saw thatCGI.escapewas already used in the codebase.This is a breaking change since it's possible that someone was already using
CGI.escapeand we would escape it twice.