-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: TypeError with hasOwnProperty
in deepFindPathToProperty
#234
fix: TypeError with hasOwnProperty
in deepFindPathToProperty
#234
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Thank you for merging 🙏 Looks like release CI was failed from closed timing of #59 log
However, https://github.com/octokit/plugin-paginate-graphql.js/releases/tag/v5.2.4 has been released. Please ping me if I need to take any action regarding that. |
No action is necessary. As long as the package was released on NPM and GitHub, it's all good. I'm not quite sure why it failed. It only failed at posting the comments on closed issues/PRs |
Thanks for sharing it 🙏 |
Resolves #58 with fix to handle non object values
Resolves #59 (comment) with adding unit test
Background is written in #137 (comment)
This change still returns errors for caller, but replaced to correct errors such as
MissingPageInfo
instead ofTypeError
.@stergion @nickfloyd How do you think this direction?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!